-
Notifications
You must be signed in to change notification settings - Fork 1
Ting/fix generator for chained calls #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe pull request introduces enhancements to the Changes
Sequence DiagramsequenceDiagram
participant PG as ProcedureGenerator
participant Node as AST Node
participant Schema as Zod Schema
PG->>Node: flattenZodSchema(node)
alt Is CallExpression
Node-->>PG: Recursive call
PG->>Node: Process child nodes
Node-->>PG: Flattened child schemas
else Is Identifier/Literal
PG-->>Schema: Generate simplified schema
end
PG-->>Schema: Return flattened schema
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This fix solves an issue of properly flattening zod schemas referenced in chained function calls.
An example:
Before the fix, references to
TypeEnum
are not flattened inFindManyInput
because it's referenced as parameters of theobject()
andmerge()
calls instead of the lastdescribe()
call.After the fix, The
TypeEnum
schema is properly flattened in all places that reference it.Summary by CodeRabbit
Tests
ProcedureGenerator
by adding a new test suite for theflattenZodSchema
methodRefactor
flattenZodSchema
method to handle nested call expressions more effectively