TypeScript sourcemap for viz-lib #7336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yoshiokatsuneo can you rebase this change and resolve conflicts? |
yoshiokatsuneo
force-pushed
the
feat/sourcemap_2
branch
from
4faf814 to
7b91ce0
Compare
yoshiokatsuneo
force-pushed
the
feat/sourcemap_2
branch
from
7b91ce0 to
106f9f3
Compare
I just rebased and resolved the conflicts. Thanks ! |
eradman
approved these changes
May 12, 2025
|
@eradman Thank you for your review and merging! |
We appreciate the careful testing on these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Before this PR, viz-lib frontend does not have TypeScript sourcemap. Not TypeScript but only transpiled JavaScript source map is available.
This PR make TypeScript sourcemap available by using webpack source-map-loader.
How is this tested?
I confirmed that TypeScript sourcemap is available on Chrome.
Note that, on Chrome, you need to uncheck "Enable ignore listing" to make source map available.
Before this PR:
After this PR:
