Skip to content

Conversation

spalmurray
Copy link
Collaborator

@spalmurray spalmurray commented Jul 31, 2025

This PR adds Cosign signing for prevent-cli binaries. We decided to go with Cosign over PGP like we have for the codecov CLI to avoid the headaches of key management and overall I'm pretty happy with how easy this is for both signer and verifier!

Closes CCMRG-452

Copy link

codecov bot commented Jul 31, 2025

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
6950 10 6940 10
View the top 3 failed test(s) by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@spalmurray spalmurray marked this pull request as ready for review July 31, 2025 17:46
@spalmurray spalmurray changed the title feat: Sign prevent-cli binaries with cosign feat: Sign sentry-prevent-cli binaries with cosign Jul 31, 2025
@spalmurray spalmurray changed the title feat: Sign sentry-prevent-cli binaries with cosign feat: Sign sentry-prevent-cli binaries with Cosign Jul 31, 2025
Copy link

linear bot commented Jul 31, 2025

@spalmurray spalmurray requested a review from mdtro August 26, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants