Fixed an error when the first test is skipped #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @getsentry this fix works for me, any chance of merging + doing a release ? |
|
Merging, will follow up with some minor tweaks. |
chadwhitacre
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
I can repro #10 and the fix here works. Would like to see a test, and this doesn't pass the linter. Will follow up with those separately ...
Merged
|
Is there any chance of this merging? |
|
Awesome, thanks for looking at this :) |
|
0.5.0 is out! Thanks for your patience. 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10