-
Notifications
You must be signed in to change notification settings - Fork 101
feat(filter): Filter webkit error #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4
−1
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c32e672
wip
TBS1996 f2f5778
Merge branch 'master' into webkitfilter
TBS1996 fec1255
Merge branch 'master' into webkitfilter
TBS1996 21afd2b
wip
TBS1996 7eef32b
Merge branch 'master' into webkitfilter
TBS1996 d0ae358
wip
TBS1996 28819bb
Merge branch 'master' into webkitfilter
TBS1996 1c4ec1a
Merge branch 'master' into webkitfilter
TBS1996 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to have also
hidden
in there as requested in the linked issue? Or having onlywebkit-masked-url
should be fine?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the way
hidden
is included seems a bit too irregular on the events here: getsentry/sentry-javascript#7993 (comment)whereas almost all have in common
webkit-masked-url:
if i want to include hidden then i think the pattern would be something like
webkit-masked-url:.*hidden
, but I'm not sure if theres a point to this because I don't think we will have false positives with the way this PR does it