Skip to content

feat(general): Add thread.errored attribute #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2019
Merged

feat(general): Add thread.errored attribute #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db6a040
feat(general): Add thread.errored attribute
jan-auer Nov 8, 2019
44b2346
test(general): Add updated Android SDK payloads
jan-auer Nov 8, 2019
5bb99b4
fix(general): Align the doc string with public docs
jan-auer Nov 8, 2019
34ac2e8
test: Accept snapshot
jan-auer Nov 8, 2019
93d4473
test(general): Fix snapshots already
jan-auer Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion general/src/protocol/thread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,15 @@ pub struct Thread {
#[metastructure(skip_serialization = "empty")]
pub raw_stacktrace: Annotated<RawStacktrace>,

/// Indicates that this thread requested the event (usually by crashing).
/// Indicates that this thread crashed (likely also crashing the application).
pub crashed: Annotated<bool>,

/// Indicates that the thread was not suspended when the event was created.
pub current: Annotated<bool>,

/// Indicates that this thread errored, which caused this event.
pub errored: Annotated<bool>,

/// Additional arbitrary fields for forwards compatibility.
#[metastructure(additional_properties)]
pub other: Object<Value>,
Expand Down Expand Up @@ -130,6 +133,7 @@ fn test_thread_roundtrip() {
"name": "myname",
"crashed": true,
"current": true,
"errored": true,
"other": "value"
}"#;
let thread = Annotated::new(Thread {
Expand All @@ -139,6 +143,7 @@ fn test_thread_roundtrip() {
raw_stacktrace: Annotated::empty(),
crashed: Annotated::new(true),
current: Annotated::new(true),
errored: Annotated::new(true),
other: {
let mut map = Map::new();
map.insert(
Expand Down
Loading