Skip to content

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Mar 28, 2025

Needed for #4592 and future EAP envelope items (Spans).

The PR itself only adds the data structure, but it is still unused, to prevent clashes with the still different OurLogs implementation, that one was renamed (until it is removed).

TODO:

  • Implement ProcessValue
  • Figure out PII

#skip-changelog

@Dav1dde Dav1dde force-pushed the dav1d/flatten-attributes branch from 83441c7 to 53551f7 Compare March 31, 2025 07:25
@Dav1dde
Copy link
Member Author

Dav1dde commented Mar 31, 2025

This approach of 'validating' during deserialization is not feasible due to needing large boilerplate of manually implementing macros and still leaving open misconfigurations through the Other hatch. Instead just keeping it as a struct with a separate validation in the processor is the better appraoch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant