feat(spanv2): Implement basic forwarding of span v2 to Kafka and upstream #5039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Aug 11, 2025
Dav1dde
force-pushed
the
dav1d/expand-span-v2
branch
from
4ab6511 to
0664f10
Compare
Dav1dde
force-pushed
the
dav1d/forward-spanv2
branch
from
7778529 to
9eb003b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
Forwardtrait for the span v2 processing pipeline. We will in a follow-up have to improve how we forward spans upstream, ideally we get rid of this additional json roundtrip, but currently that is the easiest way forward.