feat(releases): Add negated prefix to glob matching #5040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers want to allowlist certain package names for their release. For example:
foo@*
. But this is a filter so actually what happens is this deny lists the package namefoo
. To allow customers to allow list a package name we need to introduce negated prefix literals. The chosen syntax is(!foo*)*
. Where(
)
represents a group. And!
negates the group. The parentheses wrapping was chosen because it mirrors the behavior of character classes with its negated prefix. It also simplifies implementation so negation always works on a literal and is not a generalized operator that can work on any expression.