-
-
Notifications
You must be signed in to change notification settings - Fork 260
feat(web): load injected debug ids #2917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
==========================================
+ Coverage 87.59% 89.11% +1.52%
==========================================
Files 280 95 -185
Lines 9199 3106 -6093
==========================================
- Hits 8058 2768 -5290
+ Misses 1141 338 -803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
04db237 | 330.16 ms | 428.38 ms | 98.22 ms |
b47809a | 333.42 ms | 368.36 ms | 34.95 ms |
68677de | 364.41 ms | 415.61 ms | 51.20 ms |
6daa837 | 363.28 ms | 424.71 ms | 61.43 ms |
9a604e8 | 470.65 ms | 485.90 ms | 15.24 ms |
322aa66 | 284.98 ms | 341.76 ms | 56.78 ms |
acc307e | 455.04 ms | 492.26 ms | 37.22 ms |
3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
333903e | 332.76 ms | 406.86 ms | 74.10 ms |
1a93825 | 347.31 ms | 424.54 ms | 77.23 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
04db237 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
b47809a | 5.94 MiB | 6.96 MiB | 1.02 MiB |
68677de | 6.06 MiB | 7.10 MiB | 1.04 MiB |
6daa837 | 6.34 MiB | 7.29 MiB | 970.37 KiB |
9a604e8 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
322aa66 | 5.94 MiB | 6.92 MiB | 1005.75 KiB |
acc307e | 6.49 MiB | 7.56 MiB | 1.08 MiB |
3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
333903e | 6.06 MiB | 7.10 MiB | 1.04 MiB |
1a93825 | 6.27 MiB | 7.20 MiB | 956.36 KiB |
Previous results on branch: feat-web/debug-id
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ea357f9 | 442.35 ms | 521.74 ms | 79.40 ms |
f5e3a89 | 461.40 ms | 485.04 ms | 23.64 ms |
6d0e7e1 | 448.24 ms | 492.21 ms | 43.97 ms |
d143766 | 448.55 ms | 500.61 ms | 52.06 ms |
3a7db1a | 446.35 ms | 512.92 ms | 66.57 ms |
6142497 | 483.55 ms | 511.39 ms | 27.84 ms |
210c451 | 387.11 ms | 422.44 ms | 35.33 ms |
68284ff | 440.50 ms | 499.02 ms | 58.52 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ea357f9 | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
f5e3a89 | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
6d0e7e1 | 6.44 MiB | 7.43 MiB | 1013.66 KiB |
d143766 | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
3a7db1a | 6.44 MiB | 7.43 MiB | 1013.66 KiB |
6142497 | 6.44 MiB | 7.43 MiB | 1013.14 KiB |
210c451 | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
68284ff | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
07cd9e8 | 1237.04 ms | 1257.50 ms | 20.46 ms |
43abc4f | 1248.33 ms | 1272.86 ms | 24.52 ms |
b728df4 | 1287.43 ms | 1293.94 ms | 6.51 ms |
732a7b4 | 1242.17 ms | 1266.96 ms | 24.79 ms |
e442847 | 1245.96 ms | 1266.59 ms | 20.63 ms |
ffae3e3 | 1215.82 ms | 1238.49 ms | 22.67 ms |
4bcf446 | 1219.02 ms | 1242.77 ms | 23.75 ms |
7fd33d3 | 1241.92 ms | 1265.47 ms | 23.55 ms |
3f3ef0b | 1223.73 ms | 1237.67 ms | 13.94 ms |
8c0b6dc | 1258.90 ms | 1285.56 ms | 26.67 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
07cd9e8 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
43abc4f | 8.33 MiB | 9.54 MiB | 1.21 MiB |
b728df4 | 8.15 MiB | 9.15 MiB | 1020.72 KiB |
732a7b4 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
e442847 | 8.42 MiB | 9.86 MiB | 1.44 MiB |
ffae3e3 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
4bcf446 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
7fd33d3 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
3f3ef0b | 8.32 MiB | 9.38 MiB | 1.05 MiB |
8c0b6dc | 8.38 MiB | 9.74 MiB | 1.36 MiB |
Previous results on branch: feat-web/debug-id
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3a7db1a | 1275.20 ms | 1287.49 ms | 12.29 ms |
6d0e7e1 | 1254.73 ms | 1261.14 ms | 6.41 ms |
68284ff | 1257.16 ms | 1279.12 ms | 21.96 ms |
a47d886 | 1251.10 ms | 1268.14 ms | 17.04 ms |
ea357f9 | 1268.49 ms | 1280.57 ms | 12.08 ms |
6142497 | 1252.72 ms | 1267.91 ms | 15.20 ms |
210c451 | 1264.82 ms | 1273.73 ms | 8.91 ms |
d143766 | 1263.31 ms | 1281.08 ms | 17.77 ms |
f5e3a89 | 1246.09 ms | 1261.11 ms | 15.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3a7db1a | 8.43 MiB | 10.01 MiB | 1.58 MiB |
6d0e7e1 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
68284ff | 8.43 MiB | 10.01 MiB | 1.58 MiB |
a47d886 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
ea357f9 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
6142497 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
210c451 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
d143766 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
f5e3a89 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to make sure CI is happy.
This PR will stay open until v9 is releasde |
📜 Description
Adds debug id support in Flutter Web
💡 Motivation and Context
Symbolication via release/dist association is not stable enough, hard to use and confusing.
Using debug-ids makes it automatically much easier.
💚 How did you test it?
Manual test, unit test
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps