Add Python integration docs for Strawberry #8085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sentrivana
changed the title
lizokm
reviewed
Oct 2, 2023
lizokm
reviewed
Oct 2, 2023
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
lizokm
approved these changes
Oct 3, 2023
Comment on lines
132
to
136
| Strawberry comes with a (now deprecated) built-in | ||
| [Sentry tracing extension](https://strawberry.rocks/docs/extensions/sentry-tracing) | ||
| that this integration is built on. If you're using both, the Sentry SDK | ||
| integration will deactivate the built-in Strawberry extension to prevent | ||
| duplicate traces. |
There was a problem hiding this comment.
Suggested change
| Strawberry comes with a (now deprecated) built-in | |
| [Sentry tracing extension](https://strawberry.rocks/docs/extensions/sentry-tracing) | |
| that this integration is built on. If you're using both, the Sentry SDK | |
| integration will deactivate the built-in Strawberry extension to prevent | |
| duplicate traces. | |
| The Strawberry integration was built on and comes with a (now deprecated) | |
| [Sentry tracing extension](https://strawberry.rocks/docs/extensions/sentry-tracing). To prevent duplicate traces, the Sentry SDK integration will deactivate the built-in Strawberry extension if you happen to be using both. |
There was a problem hiding this comment.
Applied the change to the second sentence but left the first one as is -- Strawberry the library atm comes with a Sentry extension that we're now essentially replacing by including a Strawberry integration in Sentry instead.
Co-authored-by: Liza Mock <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
We're adding a Strawberry integration to the SDK in getsentry/sentry-python#2393, this adds the docs for it.
Direct link to the added page: https://sentry-docs-git-ivana-python-strawberry-integration.sentry.dev/platforms/python/integrations/strawberry/
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources