Skip to content

Conversation

adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 44722d1

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.18 ms 478.31 ms 61.13 ms
Size 1.70 MiB 2.35 MiB 667.12 KiB

Previous results on branch: feat/activity-lifecycle-span-origin

Startup times

Revision Plain With Sentry Diff
a1fc02c 422.73 ms 495.57 ms 72.84 ms

App size

Revision Plain With Sentry Diff
a1fc02c 1.70 MiB 2.35 MiB 667.12 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise 👍
Do we need a changelog for this?

Base automatically changed from feat/restore-multi-init-tests to 8.x.x September 23, 2024 12:14
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit e34b8a2 into 8.x.x Sep 23, 2024
12 of 21 checks passed
@adinauer adinauer deleted the feat/activity-lifecycle-span-origin branch September 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants