Skip to content

graphql 22 update instrumentation #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2024
Merged

graphql 22 update instrumentation #3974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab4a084
replace deprecated SimpleInstrumentation with SimplePerformantInstrum…
lbloder Dec 9, 2024
71febee
dump api
lbloder Dec 10, 2024
dd032f7
add readme
lbloder Dec 16, 2024
c710bc2
Merge branch '8.x.x' into feat/graphql-22-update-instrumentation
lbloder Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
- To enable the auto configuration of it, please set `-Dotel.java.global-autoconfigure.enabled=true` on the `java` command, when starting your application.
- You may also want to set `OTEL_LOGS_EXPORTER=none;OTEL_METRICS_EXPORTER=none;OTEL_TRACES_EXPORTER=none` env vars to not have the log flooded with error messages regarding OpenTelemetry features we don't use.

### Fixes
- Replace deprecated `SimpleInstrumentation` with `SimplePerformantInstrumentation` for graphql 22 ([#3974](https://github.com/getsentry/sentry-java/pull/3974))

## 8.0.0-rc.2

### Fixes
Expand Down
2 changes: 1 addition & 1 deletion sentry-graphql-22/api/sentry-graphql-22.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ public final class io/sentry/graphql22/BuildConfig {
public static final field VERSION_NAME Ljava/lang/String;
}

public final class io/sentry/graphql22/SentryInstrumentation : graphql/execution/instrumentation/SimpleInstrumentation {
public final class io/sentry/graphql22/SentryInstrumentation : graphql/execution/instrumentation/SimplePerformantInstrumentation {
public static final field SENTRY_EXCEPTIONS_CONTEXT_KEY Ljava/lang/String;
public static final field SENTRY_SCOPES_CONTEXT_KEY Ljava/lang/String;
public fun <init> (Lio/sentry/graphql/SentryGraphqlInstrumentation$BeforeSpanCallback;Lio/sentry/graphql/SentrySubscriptionHandler;Lio/sentry/graphql/ExceptionReporter;Ljava/util/List;)V
Expand Down
5 changes: 2 additions & 3 deletions sentry-graphql-22/src/main/java/io/sentry/graphql22/SentryInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@
import org.jetbrains.annotations.Nullable;
import org.jetbrains.annotations.TestOnly;

@SuppressWarnings("deprecation")
public final class SentryInstrumentation
extends graphql.execution.instrumentation.SimpleInstrumentation {
extends graphql.execution.instrumentation.SimplePerformantInstrumentation {

/**
* @deprecated please use {@link SentryGraphqlInstrumentation#SENTRY_SCOPES_CONTEXT_KEY}
Expand Down Expand Up @@ -144,7 +143,7 @@ public SentryInstrumentation(
}

@Override
@SuppressWarnings({"FutureReturnValueIgnored", "deprecation"})
@SuppressWarnings({"FutureReturnValueIgnored"})
public @NotNull DataFetcher<?> instrumentDataFetcher(
final @NotNull DataFetcher<?> dataFetcher,
final @NotNull InstrumentationFieldFetchParameters parameters,
Expand Down
Loading