Skip to content

Conversation

adinauer
Copy link
Member

📜 Description

Do not set the exception group marker ("is_exception_group": true,) when there is a suppressed exception.

Screenshot 2025-01-15 at 17 17 43

💡 Motivation and Context

Fixes #4054 but also removes the list of exceptions from the top of the issue detail page. We can fix that at a later point.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.14 ms 461.46 ms 53.32 ms
Size 1.65 MiB 2.31 MiB 677.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: fix/grouping-for-suppressed-exceptions-no-group-flag

Startup times

Revision Plain With Sentry Diff
feafa76 483.84 ms 545.07 ms 61.22 ms

App size

Revision Plain With Sentry Diff
feafa76 1.65 MiB 2.31 MiB 677.53 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit 0cf50f9 into main Jan 17, 2025
38 checks passed
@adinauer adinauer deleted the fix/grouping-for-suppressed-exceptions-no-group-flag branch January 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouping differences due to reporting suppressed exceptions
2 participants