-
-
Notifications
You must be signed in to change notification settings - Fork 456
Fix UI tests #4692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix UI tests #4692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd devices increased number of benchmark runs to increase accuracy increased passing threshold from 5% to 5.5%
Added sent envelopes to assert exception description
removed frame timestamp check, as useless in that case upgraded androidx test dependency fixed doubleInitWithSameOption UI test by waiting for the last envelope moved lazy field load after old executor service shutdown removed saucelabs test devices (now run UI tests on 1 device only) wrapped SystemEventsBreadcrumbsIntegration.unregisterReceiver in try catch fixed UserFeedbackUiTest.userFeedbackSendEnvelope UI test by checking the replay was sent, too
…o stefanosiano/fix-benchmarks
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
ee747ae | 415.92 ms | 470.15 ms | 54.23 ms |
ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
ee747ae | 357.79 ms | 421.84 ms | 64.05 ms |
ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
Previous results on branch: stefanosiano/fix-benchmarks
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
844ef43 | 405.83 ms | 429.35 ms | 23.51 ms |
27959e1 | 395.41 ms | 460.38 ms | 64.97 ms |
5df0d21 | 378.81 ms | 423.73 ms | 44.92 ms |
c91d7ea | 396.39 ms | 414.96 ms | 18.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
844ef43 | 1.58 MiB | 2.10 MiB | 530.96 KiB |
27959e1 | 1.58 MiB | 2.10 MiB | 533.13 KiB |
5df0d21 | 1.58 MiB | 2.10 MiB | 533.15 KiB |
c91d7ea | 1.58 MiB | 2.10 MiB | 533.13 KiB |
romtsn
approved these changes
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
run command to disable system animations
removed frame timestamp check, as useless in that case
upgraded androidx test dependency
fixed doubleInitWithSameOption UI test by waiting for the last envelope
moved lazy field load after old executor service shutdown
removed saucelabs test devices (now run UI tests on 1 device only)
wrapped SystemEventsBreadcrumbsIntegration.unregisterReceiver in try catch
fixed UserFeedbackUiTest.userFeedbackSendEnvelope UI test by checking the replay was sent, too
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps