Skip to content

Conversation

stefanosiano
Copy link
Member

📜 Description

run command to disable system animations
removed frame timestamp check, as useless in that case
upgraded androidx test dependency
fixed doubleInitWithSameOption UI test by waiting for the last envelope
moved lazy field load after old executor service shutdown
removed saucelabs test devices (now run UI tests on 1 device only)
wrapped SystemEventsBreadcrumbsIntegration.unregisterReceiver in try catch
fixed UserFeedbackUiTest.userFeedbackSendEnvelope UI test by checking the replay was sent, too

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…nd devices

increased number of benchmark runs to increase accuracy
increased passing threshold from 5% to 5.5%
Added sent envelopes to assert exception description
removed frame timestamp check, as useless in that case
upgraded androidx test dependency
fixed doubleInitWithSameOption UI test by waiting for the last envelope
moved lazy field load after old executor service shutdown
removed saucelabs test devices (now run UI tests on 1 device only)
wrapped SystemEventsBreadcrumbsIntegration.unregisterReceiver in try catch
fixed UserFeedbackUiTest.userFeedbackSendEnvelope UI test by checking the replay was sent, too
@stefanosiano stefanosiano marked this pull request as ready for review September 2, 2025 16:06
cursor[bot]

This comment was marked as outdated.

@stefanosiano stefanosiano mentioned this pull request Sep 2, 2025
7 tasks
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 347.48 ms 433.53 ms 86.05 ms
Size 1.58 MiB 2.10 MiB 533.18 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ee747ae 382.73 ms 435.41 ms 52.68 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
7314dbe 437.83 ms 505.64 ms 67.81 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms

App size

Revision Plain With Sentry Diff
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
7314dbe 1.58 MiB 2.10 MiB 533.45 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: stefanosiano/fix-benchmarks

Startup times

Revision Plain With Sentry Diff
844ef43 405.83 ms 429.35 ms 23.51 ms
27959e1 395.41 ms 460.38 ms 64.97 ms
5df0d21 378.81 ms 423.73 ms 44.92 ms
c91d7ea 396.39 ms 414.96 ms 18.57 ms

App size

Revision Plain With Sentry Diff
844ef43 1.58 MiB 2.10 MiB 530.96 KiB
27959e1 1.58 MiB 2.10 MiB 533.13 KiB
5df0d21 1.58 MiB 2.10 MiB 533.15 KiB
c91d7ea 1.58 MiB 2.10 MiB 533.13 KiB

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@stefanosiano stefanosiano enabled auto-merge (squash) September 5, 2025 13:09
@stefanosiano stefanosiano merged commit 2686b17 into main Sep 5, 2025
39 of 43 checks passed
@stefanosiano stefanosiano deleted the stefanosiano/fix-benchmarks branch September 5, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants