test(e2e): Run required E2E tests on PRs from forks #12791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Jul 8, 2024
Comment on lines
-917
to
+916
| (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) | ||
| (needs.job_compile_bindings_profiling_node.result == 'success' || needs.job_compile_bindings_profiling_node.result == 'skipped') |
There was a problem hiding this comment.
the deleted check here is repeated in the optional e2e test step. So it should be fine to delete here as the "problematic" step is guarded already correctly.
lforst
approved these changes
Jul 8, 2024
AbhiPrasad
approved these changes
Jul 8, 2024
|
So it seems like dependabot PRs are failing: https://github.com/getsentry/sentry-javascript/actions/runs/9842683197/job/27172764177?pr=12800 I guess they need to be examined separately? |
|
Hmm then I think we need to adjust the guard for the optional e2e tests. Looking into it. Update: Fixed via #12818 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables running E2E tests on PRs opened from forked repositories. Previously we excluded these because some E2E tests required secrets which are not available in the forks, causing e2e test runs to always fail. Now that we separated these tests from the e2e tests that don't require secrets (#12259) we should be good to re-enable the required e2e tests for external PRs.
For this to work though, I had to move the "Astro Cloudflare" test to optional tests since it requires a cloudflare token for deployment. IMO this is fine because the test doesn't have any other real tests anyway and we should create a dedicated Astro e2e test app with tests instead and add it to the required test apps.
Tested this with my forked repo and it seems like all required e2e tests are passing: #12794