Skip to content

Conversation

nwalters512
Copy link
Contributor

Prerequisite for #14968. All the tests passed with zero modification!

@mydea
Copy link
Member

mydea commented Jan 13, 2025

There seems to be one lint error remaining, in angular:

/home/runner/work/sentry-javascript/sentry-javascript/packages/angular/vitest.config.ts
  7:23  error    'UserConfig' is deprecated. import from `vitest/node` instead  deprecation/deprecation

@nwalters512
Copy link
Contributor Author

@mydea resolved in ba0a909.

@mydea
Copy link
Member

mydea commented Jan 13, 2025

Thank you! ❤️

@mydea mydea merged commit d209c69 into getsentry:develop Jan 13, 2025
139 checks passed
@nwalters512 nwalters512 deleted the upgrade-vite-vitest branch January 13, 2025 16:12
mydea pushed a commit that referenced this pull request Jan 13, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #14971
AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.

I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants