feat(browser): Record standalone LCP spans #16591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
commented
Jun 16, 2025
Comment on lines
-61
to
-62
| // TODO: Figure out if we can switch to using whenIdleOrHidden instead of onHidden | ||
| // use pagehide event from web-vitals |
There was a problem hiding this comment.
we most definitely don't want to switch to this, because idle fires too early. Removed the comment I added in #16310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements sending standalone LCP spans as an opt-in feature.
Behaviour-wise, it's mostly aligned with our prior implementation of sending CLS standalone spans (#13056):
_experiments.enableStandaloneLcpSpansoption and treat it as opt-inlcp.*span attributes as well as thelcpmeasurement to the span(depending on if we merge #16589 or this first, we might need to readjust size limit)
closes #13063