Skip to content

ref(solidstart): Use debug instead of logger #16936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

ref(solidstart): Use debug instead of logger #16936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/solidstart/src/config/withSentry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { logger } from '@sentry/core';
import { debug } from '@sentry/core';
import type { Nitro } from 'nitropack';
import { addSentryPluginToVite } from '../vite/sentrySolidStartVite';
import type { SentrySolidStartPluginOptions } from '../vite/types';
Expand Down Expand Up @@ -55,7 +55,7 @@ export function withSentry(
await addDynamicImportEntryFileWrapper({ nitro, rollupConfig: config, sentryPluginOptions });

sentrySolidStartPluginOptions.debug &&
logger.log(
debug.log(
'Wrapping the server entry file with a dynamic `import()`, so Sentry can be preloaded before the server initializes.',
);
} else {
Expand Down
10 changes: 5 additions & 5 deletions packages/solidstart/src/server/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { EventProcessor, Options } from '@sentry/core';
import { logger } from '@sentry/core';
import { debug } from '@sentry/core';
import { flush, getGlobalScope } from '@sentry/node';
import { DEBUG_BUILD } from '../common/debug-build';

Expand All @@ -9,11 +9,11 @@ export async function flushIfServerless(): Promise<void> {

if (isServerless) {
try {
DEBUG_BUILD && logger.log('Flushing events...');
DEBUG_BUILD && debug.log('Flushing events...');
await flush(2000);
DEBUG_BUILD && logger.log('Done flushing events');
DEBUG_BUILD && debug.log('Done flushing events');
} catch (e) {
DEBUG_BUILD && logger.log('Error while flushing events:\n', e);
DEBUG_BUILD && debug.log('Error while flushing events:\n', e);
}
}
}
Expand Down Expand Up @@ -46,7 +46,7 @@ export function filterLowQualityTransactions(options: Options): void {
}
// Filter out transactions for build assets
if (event.transaction?.match(/^GET \/_build\//)) {
options.debug && logger.log('SolidStartLowQualityTransactionsFilter filtered transaction', event.transaction);
options.debug && debug.log('SolidStartLowQualityTransactionsFilter filtered transaction', event.transaction);
return null;
}
return event;
Expand Down
Loading