fix(ember): Restrict compatibility tests to CI #3069
Merged
+40
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
commented
Nov 24, 2020
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-only-run-multiple-ember-tests-in-CI
branch
from
d05cc83 to
ee6259b
Compare
k-fish
approved these changes
Nov 26, 2020
lobsterkatie
force-pushed
the
kmclb-only-run-multiple-ember-tests-in-CI
branch
from
ee6259b to
d2f8927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a check before running ember tests, to see whether we're in a CI environment or not, and skips running tests against multiple versions of ember if we aren't (under the assumption that while we like the security of doing ALL of the checks in CI, testing against one ember version locally should be enough to let us know whether or not we broke something).
Doing this speeds up local ember tests by a factor of 25x-30x.
WIP because bash is mysterious.EDIT: Leaving a note here rather than just deleting the above WIP comment on the off chance it helps one of us in the future. The issue was that in ubuntu, though the login shell is
bash, the default shell isdash, anddashdoesn't have the[[ logical-test ]]construct. Therefore calling my script with. <script>wasn't enough - I had to specifically ask forbash, as inbash <script>.