feat(core): Set custom transaction source for event processors #5722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
size-limit report 📦
|
lforst
approved these changes
Sep 12, 2022
Base automatically changed from
abhi-transaction-name-change-interface
to
master
September 12, 2022 13:10
lobsterkatie
approved these changes
Sep 13, 2022
Comment on lines
+663
to
+667
| if (isTransaction && transactionInfo && processedEvent.transaction !== event.transaction) { | ||
| const source = 'custom'; |
There was a problem hiding this comment.
When I first saw this, my gut reaction was to worry that it was going to break the RequestData integration, until I realized that the integration shouldn't ever change a transaction event's transaction, only an error event's transaction. So we're good there, but still, I wonder if it might not be worth putting a note here basically saying "we know none of our stuff does this, so if it happened, it must be because of some custom event processor added by the user."
AbhiPrasad
force-pushed
the
abhi-baseclient-name-changes
branch
2 times, most recently
from
113d518 to
5b360ef
Compare
AbhiPrasad
force-pushed
the
abhi-baseclient-name-changes
branch
from
5b360ef to
6d15645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5679
Dependent on #5714 merging
This PR updates
BaseClientclass to set a custom transaction source if event processors change the transaction name. It also adds metadata around a transaction name change when this is done.