Skip to content

Add SynchronousTransport implementation #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

willhcr
Copy link
Contributor

@willhcr willhcr commented Oct 16, 2024

Enabled similarly to SynchronousWorker

Changes licensed under MIT terms

@willhcr willhcr changed the title 3 add synchronoustransport support Add SynchronousTransport implementation Oct 16, 2024
@bruno-garcia bruno-garcia requested a review from vaind October 20, 2024 05:49
@vaind
Copy link
Collaborator

vaind commented Oct 21, 2024

Thanks for submitting this as a PR. It seems like we don't have any tests that exercise a real transport so I've tried to test this in the sample. It seems to work most of the times but sometimes I get an error:

DEBUG: [Sentry] Sending content synchronously, Content-Length: 2366                                                     
Write-Error: [Sentry] Failure to capture transaction: 5be2b4b4cdb3b2bf                                                  
                                                                                                                        
ErrorRecord                                       WasThrownFromThrowStatement TargetSite                                                                                          Message                                           Data
-----------                                       --------------------------- ----------                                                                                          -------                                           ----
…                                                                       False Void CheckActionPreference(System.Management.Automation.Language.FunctionContext, System.Exception) …                                                 {[System.Management.Automation.Interpreter.InterpretedFrameInfo, System.Management.Automation.Interpreter.Interp…
              

I'm having a look what's going on and trying to add a unit test while doing that.

@vaind vaind mentioned this pull request Oct 21, 2024
@vaind vaind closed this in #62 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants