Skip to content

chore(deps): update Dotnet SDK to v4.13.0 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2024

Bumps dependencies/Sentry.properties from 4.12.1 to 4.13.0.

Auto-generated by a dependency updater.

Changelog

4.13.0

Features

  • Limited experimental support for Session Replay Recording on Android (#3552)

Fixes

  • When using OTel and ASP.NET Core the SDK could try to process OTel spans after the SDK had been closed (#3726)

Dependencies

4.12.2

Features

  • Android - allow logcat attachments to be previewed in Sentry (#3711)
  • Added a SetBeforeScreenshotCapture callback to the options: allowing the user to set an action before the screenshot is taken (#3661)
  • Make Sentry.AspNetCore.Blazor.WebAssembly generally available. (#3674)

Fixes

  • Events from NDK on Android will report sdk.name sentry.native.android.dotnet (#3682)

Dependencies

@bruno-garcia bruno-garcia force-pushed the deps/dependencies/Sentry.properties branch from 9e179ae to bf80e10 Compare November 3, 2024 03:09
@github-actions github-actions bot changed the title chore(deps): update Dotnet SDK to v4.12.2 chore(deps): update Dotnet SDK to v4.13.0 Nov 6, 2024
@bruno-garcia bruno-garcia force-pushed the deps/dependencies/Sentry.properties branch from bf80e10 to 47c2f92 Compare November 6, 2024 03:02
@bruno-garcia
Copy link
Member

bruno-garcia commented Nov 7, 2024

Exception: D:\a\sentry-powershell\sentry-powershell\tests\throwing.ps1:7
Line |
   7 |      funcB $action $param
     |      ~~~~~~~~~~~~~~~~~~~~
     | error
[+] D:\a\sentry-powershell\sentry-powershell\tests\stacktrace.tests.ps1 4.12s (4.06s|42ms)

3 tests are failing. Seems like flakes?

@bruno-garcia bruno-garcia requested a review from vaind November 7, 2024 02:37
@vaind
Copy link
Collaborator

vaind commented Nov 7, 2024

3 tests are failing. Seems like flakes?

I don't think so. They fail consistently since 4.12.2 update. CI on main passes just fine (I've just rerun the previous build). I'll need to have a look at what changed in the .net

@vaind
Copy link
Collaborator

vaind commented Nov 7, 2024

Exception: D:\a\sentry-powershell\sentry-powershell\tests\throwing.ps1:7
Line |
   7 |      funcB $action $param
     |      ~~~~~~~~~~~~~~~~~~~~
     | error
[+] D:\a\sentry-powershell\sentry-powershell\tests\stacktrace.tests.ps1 4.12s (4.06s|42ms)

3 tests are failing. Seems like flakes?

BTW what you've copy-pasted is actually not a test failure, just a log output. Tests fail because of this:

At D:\a\sentry-powershell\sentry-powershell\modules\Sentry\private\ScopeIntegration.ps1:3 char:35
+     Register([Sentry.IHub] $hub, [Sentry.SentryOptions] $options)
+                                   ~~~~~~~~~~~~~~~~~~~~
Unable to find type [Sentry.SentryOptions].
    + CategoryInfo          : ParserError: (:) [], ParseException
    + FullyQualifiedErrorId : TypeNotFound
 
At D:\a\sentry-powershell\sentry-powershell\modules\Sentry\private\SynchronousWorker.ps1:6 char:13
+     hidden [Sentry.SentryOptions] $options
+             ~~~~~~~~~~~~~~~~~~~~
Unable to find type [Sentry.SentryOptions].
At D:\a\sentry-powershell\sentry-powershell\modules\Sentry\private\SynchronousWorker.ps1:9 char:24
+     SynchronousWorker([Sentry.SentryOptions] $options)
+                        ~~~~~~~~~~~~~~~~~~~~
Unable to find type [Sentry.SentryOptions].
    + CategoryInfo          : ParserError: (:) [], ParseException
    + FullyQualifiedErrorId : TypeNotFound
 
At D:\a\sentry-powershell\sentry-powershell\modules\Sentry\private\SynchronousTransport.ps1:11 char:27
+     SynchronousTransport([Sentry.SentryOptions] $options) : base($opt ...
+                           ~~~~~~~~~~~~~~~~~~~~
Unable to find type [Sentry.SentryOptions].
    + CategoryInfo          : ParserError: (:) [], ParseException
    + FullyQualifiedErrorId : TypeNotFound
 
At D:\a\sentry-powershell\sentry-powershell\tests\utils.ps1:28 char:6
+     [Sentry.SentryOptions] $Options
+      ~~~~~~~~~~~~~~~~~~~~
Unable to find type [Sentry.SentryOptions].
At D:\a\sentry-powershell\sentry-powershell\tests\utils.ps1:31 char:35
+     Register([Sentry.IHub] $hub, [Sentry.SentryOptions] $options)
+                                   ~~~~~~~~~~~~~~~~~~~~
Unable to find type [Sentry.SentryOptions].
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : TypeNotFound
 
Error: [-] Out-Sentry captures expected stack traces for command argument.Windows PowerShell 5.2s (5.19s|2ms)

and since it is an integration test faulure Windows PowerShell (in the test name) and additionally because the Windows Powershell CI build fails while loading the module:

DEBUG: Loading assemblies from D:\a\sentry-powershell\sentry-powershell\modules\Sentry\lib\net462:
DEBUG: Loading assembly: Microsoft.Bcl.AsyncInterfaces.dll
DEBUG: Microsoft.Bcl.AsyncInterfaces, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b[13](https://github.com/getsentry/sentry-powershell/actions/runs/11696434860/job/32573543562#step:7:14)ffcd2ddd51
DEBUG: Loading assembly: Sentry.dll
DEBUG: Sentry, Version=4.13.0.0, Culture=neutral, PublicKeyToken=fba2ec45388e2af0
DEBUG: Loading assembly: System.Buffers.dll
DEBUG: System.Buffers, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
DEBUG: Loading assembly: System.Collections.Immutable.dll
DEBUG: System.Collections.Immutable, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
DEBUG: Loading assembly: System.Memory.dll
DEBUG: System.Memory, Version=4.0.1.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
DEBUG: Loading assembly: System.Net.Http.dll
DEBUG: System.Net.Http, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
DEBUG: Loading assembly: System.Numerics.Vectors.dll
DEBUG: System.Numerics.Vectors, Version=4.1.4.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
DEBUG: Loading assembly: System.Reflection.Metadata.dll
DEBUG: System.Reflection.Metadata, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
DEBUG: Loading assembly: System.Runtime.CompilerServices.Unsafe.4.dll
DEBUG: System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
DEBUG: Loading assembly: System.Runtime.CompilerServices.Unsafe.6.dll
DEBUG: System.Runtime.CompilerServices.Unsafe, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
DEBUG: Loading assembly: System.Text.Encodings.Web.dll
DEBUG: System.Text.Encodings.Web, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
DEBUG: Loading assembly: System.Text.Json.dll
DEBUG: System.Text.Json, Version=6.0.0.8, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
DEBUG: Loading assembly: System.Threading.Tasks.Extensions.dll
DEBUG: System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51
DEBUG: Loading assembly: System.ValueTuple.dll
DEBUG: System.ValueTuple, Version=4.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51

ModuleType Version    Name                                ExportedCommands                                             
---------- -------    ----                                ----------------                                             
Script     0.0        assemblies-loader                                                                                
ForEach-Object : At D:\a\sentry-powershell\sentry-powershell\modules\Sentry\private\ScopeIntegration.ps1:3 char:35
+     Register([Sentry.IHub] $hub, [Sentry.SentryOptions] $options)
+                                   ~~~~~~~~~~~~~~~~~~~~
Unable to find type [Sentry.SentryOptions].
At D:\a\sentry-powershell\sentry-powershell\modules\Sentry\Sentry.psm1:[14](https://github.com/getsentry/sentry-powershell/actions/runs/11696434860/job/32573543562#step:7:15) char:44
+ Get-ChildItem $publicDir -Filter '*.ps1' | ForEach-Object {
+                                            ~~~~~~~~~~~~~~~~
    + CategoryInfo          : ParserError: (:) [ForEach-Object], ParseException
    + FullyQualifiedErrorId : TypeNotFound,Microsoft.PowerShell.Commands.ForEachObjectCommand
 
Error: Process completed with exit code 1.

That indicates the DLL couldn't be loaded which can only mean it's missing of one of the required dependencies (DLLs) is missing or a wrong version. A look at the diff linked in this PR description shows that System.Text.Json was updated so we need to bump it here as well.

@vaind vaind merged commit ea8172e into main Nov 7, 2024
13 checks passed
@vaind vaind deleted the deps/dependencies/Sentry.properties branch November 7, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants