IGNORED_LOGGERS is part of broken shutdown

[untitaker]

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/local/lib/python2.7/site-packages/sentry_sdk/integrations/threading.py", line 69, in run
    reraise(*_capture_exception())
  File "/usr/local/lib/python2.7/site-packages/sentry_sdk/integrations/threading.py", line 67, in run
    return old_run_func(self, *a, **kw)
  File "/usr/local/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/local/lib/python2.7/site-packages/sentry/utils/metrics.py", line 101, in worker
    logger.exception("Unable to incr internal metric")
  File "/usr/local/lib/python2.7/logging/__init__.py", line 1207, in exception
    self.error(msg, *args, **kwargs)
  File "/usr/local/lib/python2.7/logging/__init__.py", line 1200, in error
    self._log(ERROR, msg, args, **kwargs)
  File "/usr/local/lib/python2.7/logging/__init__.py", line 1293, in _log
    self.handle(record)
  File "/usr/local/lib/python2.7/logging/__init__.py", line 1303, in handle
    self.callHandlers(record)
  File "/usr/local/lib/python2.7/site-packages/sentry_sdk/integrations/logging.py", line 89, in sentry_patched_callhandlers
    if record.name not in _IGNORED_LOGGERS:
TypeError: argument of type 'NoneType' is not iterable

https://github.com/getsentry/onpremise/pull/615/checks?check_run_id=1037005000

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[antonpirker]

@untitaker Do you know if this is still relevant? Is this something we should keep and fix?

[untitaker]

I think so. The fix is to keep a local reference to the IGNORED_LOGGERS variable such that it doesn't get cleared on process shutdown.

[antonpirker]

Wanted to fix this, but can not reproduce.

There is a thread and in that thread a logger.exception() is done and that's it, right? Is this Python 2 only?