Skip to content

Parse gevent version supporting non-numeric parts. #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Parse gevent version supporting non-numeric parts. #1243

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c02b731
fix #1163
mgaitan Nov 8, 2021
ce1df2c
Merge remote-tracking branch 'upstream/master' into fix_1163
mgaitan Nov 19, 2021
c3e2a98
fix code style
mgaitan Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sentry_sdk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,9 @@ def _is_contextvars_broken():
from gevent.monkey import is_object_patched # type: ignore

# Get the MAJOR and MINOR version numbers of Gevent
version_tuple = tuple([int(part) for part in gevent.__version__.split(".")[:2]])
version_tuple = tuple(
[int(part) for part in re.split(r"a|b|rc|\.", gevent.__version__)[:2]]
)
if is_object_patched("threading", "local"):
# Gevent 20.9.0 depends on Greenlet 0.4.17 which natively handles switching
# context vars when greenlets are switched, so, Gevent 20.9.0+ is all fine.
Expand Down