perf(profiling): Additionl performance improvements to the profiler #1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds additional performance improvements to the profiler after observing the following: - extracting filename information is expensive, so add a cache on to allow reuse of results - extracting the full frame information is expensive, but we only need to do it once since the subsequent occurrences can reuse previous results - the abs_path + lineno is sufficient to uniquely identify a frame, so use that as the frame key
…ents-to-the-profiler
antonpirker
approved these changes
Apr 12, 2023
Zylphrex
deleted the
txiao/perf/additional-performance-improvements-to-the-profiler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds additional performance improvements to the profiler after observing the following: