Skip to content

(1) Move add_breadcrumb and session function from Hub to Scope #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 6, 2023
Merged

(1) Move add_breadcrumb and session function from Hub to Scope #2544

merged 10 commits into from
Dec 6, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Nov 29, 2023 •
edited
Loading

Moved some functionality from Hub to Scope or Client:

  • moved add_breadcrumb from Hub to Scope
  • moved session functions from Hub to Scope
  • moved get_integration1 from Hub to Client.

This is preparation work for refactoring how we deal with Hubs and Scopes in the future.
Each commit is moving one function, so it should be easy to review commit by commit.

@antonpirker antonpirker marked this pull request as ready for review November 29, 2023 16:28
@antonpirker antonpirker changed the title Refatoring Hub Move add_breadcrumb and session function from Hub to Scope Dec 1, 2023
@antonpirker antonpirker mentioned this pull request Dec 1, 2023
Merged
@antonpirker antonpirker changed the title Move add_breadcrumb and session function from Hub to Scope (1) Move add_breadcrumb and session function from Hub to Scope Dec 4, 2023
sentrivana
sentrivana approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this reviewable by commit!

@antonpirker antonpirker enabled auto-merge (squash) December 6, 2023 07:45
auto-merge was automatically disabled December 6, 2023 07:49

Pull Request is not mergeable

auto-merge was automatically disabled December 6, 2023 07:49

Pull Request is not mergeable

@antonpirker antonpirker merged commit 354d7bb into master Dec 6, 2023
@antonpirker antonpirker deleted the antonpirker/refactor-hub branch December 6, 2023 08:02
antonpirker added a commit that referenced this pull request Dec 7, 2023
@antonpirker
Revert "Move add_breadcrumb and session function from Hub to Scope (#…
ad6d183 
…2544)"

This reverts commit 354d7bb.
@antonpirker antonpirker mentioned this pull request Dec 7, 2023
Merged
sentrivana pushed a commit that referenced this pull request Dec 7, 2023
@antonpirker
Revert "Move add_breadcrumb and session function from Hub to Scope (#…
38ec650 
…2544)" (#2574)

This reverts commit 354d7bb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana