ref(logging): New scopes API in LoggingIntegration #2855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5af188e.
sentrivana
approved these changes
Mar 19, 2024
sentrivana
reviewed
Mar 19, 2024
Comment on lines
+186
to
188
| client = sentry_sdk.get_client() | ||
| if not client.is_active(): | ||
| return |
There was a problem hiding this comment.
Not 100% sure but it might be we don't need this check since if the current client is a noop client, you can still do stuff with it, it'll just all be noop.
There was a problem hiding this comment.
I am not sure, there is a lot of code after this line that we skip over. Even if this is not strictly necessary, it might improve performance slightly since we skip a lot of operations. I will merge for now without removing this, we can always change it later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new scopes API in LoggingIntegration. I also tested these changes manually: https://sentry-sdks.sentry.io/issues/5083315970/?project=4505239425777664&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=1h&stream_index=1&utc=true
Fixes GH-2852