Skip to content

Added timeout to HTTP requests in CloudResourceContextIntegration #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

antonpirker
Copy link
Member

The URL that works in EC2 does not work in ECS, this can lead to the HTTP request getting stuck.

Fixes #2376

@antonpirker antonpirker requested a review from sentrivana March 6, 2025 13:18
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.56%. Comparing base (7deebf0) to head (9d11787).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/cloud_resource_context.py 70.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4120      +/-   ##
==========================================
- Coverage   79.59%   79.56%   -0.03%     
==========================================
  Files         140      140              
  Lines       15581    15594      +13     
  Branches     2643     2647       +4     
==========================================
+ Hits        12401    12407       +6     
- Misses       2343     2349       +6     
- Partials      837      838       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/cloud_resource_context.py 89.79% <70.00%> (-3.49%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antonpirker antonpirker enabled auto-merge (squash) March 10, 2025 13:50
@antonpirker antonpirker merged commit a97c53c into master Mar 10, 2025
139 of 140 checks passed
@antonpirker antonpirker deleted the antonpirker/fix/cloud_resource_context_timeout branch March 10, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudResourceContextIntegration freezing in ECS Container
2 participants