Skip to content

Fix memory leak by not piling up breadcrumbs forever in Spark workers. #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Fix memory leak by not piling up breadcrumbs forever in Spark workers. #4167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
063f777
Do not pile up breakcrumbs forever
antonpirker Mar 19, 2025
22ef829
Merge branch 'master' into antonpirker/fix/spark-memory-leak
antonpirker Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sentry_sdk/integrations/spark/spark_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ def _set_app_properties():

spark_context = SparkContext._active_spark_context
if spark_context:
spark_context.setLocalProperty("sentry_app_name", spark_context.appName)
spark_context.setLocalProperty(
"sentry_application_id", spark_context.applicationId
"sentry_app_name",
spark_context.appName,
)
spark_context.setLocalProperty(
"sentry_application_id",
spark_context.applicationId,
)


Expand Down Expand Up @@ -231,12 +235,14 @@ def _add_breadcrumb(
data=None, # type: Optional[dict[str, Any]]
):
# type: (...) -> None
sentry_sdk.get_global_scope().add_breadcrumb(
sentry_sdk.get_isolation_scope().add_breadcrumb(
level=level, message=message, data=data
)

def onJobStart(self, jobStart): # noqa: N802,N803
# type: (Any) -> None
sentry_sdk.get_isolation_scope().clear_breadcrumbs()

message = "Job {} Started".format(jobStart.jobId())
self._add_breadcrumb(level="info", message=message)
_set_app_properties()
Expand Down
Loading