Skip to content

Trying to prevent the grpc setup from being flaky #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 3, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Apr 2, 2025

Automatically select a port and not set it by hand also make creating of the channel more stable.

@antonpirker antonpirker requested a review from a team as a code owner April 2, 2025 15:16
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (5147ab9) to head (bde3e15).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4233      +/-   ##
==========================================
+ Coverage   79.52%   79.53%   +0.01%     
==========================================
  Files         142      142              
  Lines       15898    15898              
  Branches     2721     2721              
==========================================
+ Hits        12643    12645       +2     
  Misses       2389     2389              
+ Partials      866      864       -2     

see 4 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as draft April 3, 2025 09:49
@antonpirker antonpirker marked this pull request as ready for review April 3, 2025 12:10
@antonpirker
Copy link
Member Author

I have now run the tests five times in a row without the grpc tests being flaky, so I guess this works. (the last time another flaky test failed, but it was not grpc)

@antonpirker antonpirker requested a review from sentrivana April 3, 2025 12:11
@antonpirker antonpirker merged commit adcfa0f into master Apr 3, 2025
138 checks passed
@antonpirker antonpirker deleted the antonpirker/fix/grpc-test-flakyness branch April 3, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants