-
Notifications
You must be signed in to change notification settings - Fork 537
Trying to prevent the grpc setup from being flaky #4233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4233 +/- ##
==========================================
+ Coverage 79.52% 79.53% +0.01%
==========================================
Files 142 142
Lines 15898 15898
Branches 2721 2721
==========================================
+ Hits 12643 12645 +2
Misses 2389 2389
+ Partials 866 864 -2 |
…entry/sentry-python into antonpirker/fix/grpc-test-flakyness
I have now run the tests five times in a row without the grpc tests being flaky, so I guess this works. (the last time another flaky test failed, but it was not grpc) |
sentrivana
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically select a port and not set it by hand also make creating of the channel more stable.