test(tracing): Simplify static/classmethod tracing tests #4278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4278 +/- ##
==========================================
- Coverage 79.54% 79.52% -0.03%
==========================================
Files 142 142
Lines 15907 15907
Branches 2723 2723
==========================================
- Hits 12654 12650 -4
- Misses 2389 2390 +1
- Partials 864 867 +3 |
|
ah looks like there are some interactions between the tests here |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tracing-static-class-test-improvements
branch
from
742bd9f to
5348bf5
Compare
These tests were causing flakes where the mock method was being called more than once. The tests were also difficult to understand. This change removes the need for mocking (hopefully increasing test stability) and also should hopefully make it easier to understand what these tests are meant to be checking
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tracing-static-class-test-improvements
branch
from
5348bf5 to
0f0eddb
Compare
sentrivana
approved these changes
Apr 14, 2025
szokeasaurusrex
deleted the
szokeasaurusrex/tracing-static-class-test-improvements
branch
szokeasaurusrex
added a commit
that referenced
this pull request
Apr 14, 2025
Port of #4278 for POTel. <!-- Describe your PR here --> --- Thank you for contributing to `sentry-python`! Please add tests to validate your changes, and lint your code using `tox -e linters`. Running the test suite on your PR might require maintainer approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were causing flakes where the mock method was being called more than once. The tests were also difficult to understand.
This change removes the need for mocking (hopefully increasing test stability) and also should hopefully make it easier to understand what these tests are meant to be checking