tests: Fix version picking in toxgen #4323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toxgen should only consider the highest patch release of each
major.minor
version. For the most part this was working fine as long as the releases were ordered as expected in PyPI, but in cases where a lower patch version succeeded a higher patch version in the release list from PyPI, we would incorrectly consider the lower patch version as well, instead of ignoring it in favor of the higher patch.Example:
[1.2.3, 1.2.4, 1.2.5, 1.2.2]
from PyPI (in that order)1.2.3, 1.2.4, 1.2.5
into one version,1.2.5
, as expected1.2.2
will not disappear into1.2.5
because of a faulty check in toxgen and will instead be considered as a new version[1.2.5, 1.2.2]
instead of just[1.2.5]
, which then results in picking versions that are not nicely spaced apart