Skip to content

Remove explicit __del__'s in threaded classes #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Remove explicit __del__'s in threaded classes #4590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sentry_sdk/monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,3 @@ def downsample_factor(self):
def kill(self):
# type: () -> None
self._running = False

def __del__(self):
# type: () -> None
self.kill()
4 changes: 0 additions & 4 deletions sentry_sdk/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,3 @@ def add_session(
def kill(self):
# type: (...) -> None
self.__shutdown_requested.set()

def __del__(self):
# type: (...) -> None
self.kill()
7 changes: 0 additions & 7 deletions sentry_sdk/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,6 @@ def is_healthy(self):
# type: (Self) -> bool
return True

def __del__(self):
# type: (Self) -> None
try:
self.kill()
except Exception:
pass


def _parse_rate_limits(header, now=None):
# type: (str, Optional[datetime]) -> Iterable[Tuple[Optional[EventDataCategory], datetime]]
Expand Down
Loading