Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 4, 2025

  • move beam under toxgen
  • lower the waiting time between pypi requests

Ref #4506

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.86%. Comparing base (ff9b1c3) to head (bca6960).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
+ Coverage   84.84%   84.86%   +0.01%     
==========================================
  Files         157      157              
  Lines       16138    16138              
  Branches     2744     2744              
==========================================
+ Hits        13692    13695       +3     
+ Misses       1656     1653       -3     
  Partials      790      790              

see 4 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review September 4, 2025 10:43
@sentrivana sentrivana requested a review from a team as a code owner September 4, 2025 10:43
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CI Matrix Update Breaks Python 3.8 Compatibility

Removing Python 3.8 from the CI matrix means several task integrations (beam, arq, celery, dramatiq, spark) with existing Python 3.8 tox configurations are no longer tested, creating a coverage gap. Also, the "Test beam latest" step fails because the workflow tries to run a beam-latest tox environment, but tox.ini now only defines specific versioned beam targets.

.github/workflows/test-integrations-tasks.yml#L31-L32

matrix:
python-version: ["3.7","3.10","3.11","3.12","3.13"]

.github/workflows/test-integrations-tasks.yml#L66-L70

set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-beam-latest"
- name: Test celery latest
run: |
set -x # print commands that are executed

Fix in Cursor Fix in Web


@sentrivana
Copy link
Contributor Author

sentrivana commented Sep 4, 2025

Removing Python 3.8 from the CI matrix means several task integrations (beam, arq, celery, dramatiq, spark) with existing Python 3.8 tox configurations are no longer tested, creating a coverage gap. Also, the "Test beam latest" step fails because the workflow tries to run a beam-latest tox environment, but tox.ini now only defines specific versioned beam targets.

.github/workflows/test-integrations-tasks.yml#L31-L32

.github/workflows/test-integrations-tasks.yml#L66-L70

Moving a test suite under toxgen effectively means removing it from the latest group and moving it under pinned, so this is expected. We are, in fact, testing more than before, as toxgen automatically picks a handful of versions to test -- unlike the previously hardcoded one pinned version + one latest version.

@sentrivana sentrivana merged commit c378c2d into master Sep 4, 2025
134 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/beam branch September 4, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants