Skip to content

tests: Move quart under toxgen #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2025
Merged

tests: Move quart under toxgen #4775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b28d0ee
tests: Move quart under toxgen
sentrivana Sep 8, 2025
bc6d73a
.
sentrivana Sep 8, 2025
5859094
.
sentrivana Sep 8, 2025
1998aff
Merge branch 'master' into ivana/toxgen/quart
sentrivana Sep 8, 2025
e8070a7
.
sentrivana Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-integrations-web-2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8","3.9","3.12","3.13"]
python-version: ["3.9","3.12","3.13"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
Expand Down
14 changes: 14 additions & 0 deletions scripts/populate_tox/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,20 @@
"*": ["werkzeug<2.1.0"],
},
},
"quart": {
"package": "quart",
"deps": {
"*": ["quart-auth", "pytest-asyncio", "Werkzeug"],
">=0.19": ["quart-flask-patch"],
"<0.19": [
"blinker<1.6",
"jinja2<3.1.0",
"Werkzeug<2.3.0",
"hypercorn<0.15.0",
],
"py3.8": ["taskgroup==0.0.0a4"],
},
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Quart Configuration Missing Version-Specific Dependencies

The quart configuration is missing version-specific dependencies for versions >=0.19. The previous setup included quart-flask-patch and Werkzeug>=3.0.0 for these versions, but the current configuration only defines dependencies for <0.19. This leaves newer quart versions without these critical dependencies.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Quart Configuration Fails Dependency Management

The quart configuration has two issues: it includes conflicting Werkzeug dependencies for versions < 0.19 (unconstrained and <2.3.0), and it omits quart-flask-patch and Werkzeug>=3.0.0 for versions >= 0.19, which were previously required.

Fix in Cursor Fix in Web

"redis_py_cluster_legacy": {
"package": "redis-py-cluster",
},
Expand Down
4 changes: 2 additions & 2 deletions scripts/populate_tox/populate_tox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
# pypi package to install in different versions).
#
# Test suites that will have to remain hardcoded since they don't fit the
# toxgen usecase
# toxgen usecase (there is no one package that should be tested in different
# versions)
"asgi",
"aws_lambda",
"cloud_resource_context",
Expand All @@ -70,7 +71,6 @@
"gcp",
"httpx",
"pure_eval",
"quart",
"ray",
"redis",
"requests",
Expand Down
19 changes: 0 additions & 19 deletions scripts/populate_tox/tox.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ envlist =
# pure_eval
{py3.6,py3.12,py3.13}-pure_eval

# Quart
{py3.7,py3.11}-quart-v{0.16}
{py3.8,py3.11,py3.12}-quart-v{0.19}
{py3.8,py3.12,py3.13}-quart-latest

# Ray
{py3.10,py3.11}-ray-v{2.34}
{py3.10,py3.11}-ray-latest
Expand Down Expand Up @@ -184,20 +179,6 @@ deps =
# pure_eval
pure_eval: pure_eval

# Quart
quart: quart-auth
quart: pytest-asyncio
quart-{v0.19,latest}: quart-flask-patch
quart-v0.16: blinker<1.6
quart-v0.16: jinja2<3.1.0
quart-v0.16: Werkzeug<2.1.0
quart-v0.16: hypercorn<0.15.0
quart-v0.16: quart~=0.16.0
quart-v0.19: Werkzeug>=3.0.0
quart-v0.19: quart~=0.19.0
{py3.8}-quart: taskgroup==0.0.0a4
quart-latest: quart

# Ray
ray-v2.34: ray~=2.34.0
ray-latest: ray
Expand Down
48 changes: 28 additions & 20 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# The file (and all resulting CI YAMLs) then need to be regenerated via
# "scripts/generate-test-files.sh".
#
# Last generated: 2025-09-08T07:44:56.804943+00:00
# Last generated: 2025-09-08T11:35:09.849536+00:00

[tox]
requires =
Expand Down Expand Up @@ -64,11 +64,6 @@ envlist =
# pure_eval
{py3.6,py3.12,py3.13}-pure_eval

# Quart
{py3.7,py3.11}-quart-v{0.16}
{py3.8,py3.11,py3.12}-quart-v{0.19}
{py3.8,py3.12,py3.13}-quart-latest

# Ray
{py3.10,py3.11}-ray-v{2.34}
{py3.10,py3.11}-ray-latest
Expand Down Expand Up @@ -302,6 +297,11 @@ envlist =
{py3.6,py3.8,py3.9}-pyramid-v1.10.8
{py3.6,py3.10,py3.11}-pyramid-v2.0.2

{py3.7,py3.9,py3.10}-quart-v0.16.3
{py3.7,py3.9,py3.10}-quart-v0.17.0
{py3.7,py3.10,py3.11}-quart-v0.18.4
{py3.9,py3.12,py3.13}-quart-v0.20.0

{py3.8,py3.10,py3.11}-starlite-v1.48.1
{py3.8,py3.10,py3.11}-starlite-v1.49.0
{py3.8,py3.10,py3.11}-starlite-v1.50.2
Expand Down Expand Up @@ -403,20 +403,6 @@ deps =
# pure_eval
pure_eval: pure_eval

# Quart
quart: quart-auth
quart: pytest-asyncio
quart-{v0.19,latest}: quart-flask-patch
quart-v0.16: blinker<1.6
quart-v0.16: jinja2<3.1.0
quart-v0.16: Werkzeug<2.1.0
quart-v0.16: hypercorn<0.15.0
quart-v0.16: quart~=0.16.0
quart-v0.19: Werkzeug>=3.0.0
quart-v0.19: quart~=0.19.0
{py3.8}-quart: taskgroup==0.0.0a4
quart-latest: quart

# Ray
ray-v2.34: ray~=2.34.0
ray-latest: ray
Expand Down Expand Up @@ -774,6 +760,28 @@ deps =
pyramid-v2.0.2: pyramid==2.0.2
pyramid: werkzeug<2.1.0

quart-v0.16.3: quart==0.16.3
quart-v0.17.0: quart==0.17.0
quart-v0.18.4: quart==0.18.4
quart-v0.20.0: quart==0.20.0
quart: quart-auth
quart: pytest-asyncio
quart: Werkzeug
quart-v0.20.0: quart-flask-patch
quart-v0.16.3: blinker<1.6
quart-v0.16.3: jinja2<3.1.0
quart-v0.16.3: Werkzeug<2.3.0
quart-v0.16.3: hypercorn<0.15.0
quart-v0.17.0: blinker<1.6
quart-v0.17.0: jinja2<3.1.0
quart-v0.17.0: Werkzeug<2.3.0
quart-v0.17.0: hypercorn<0.15.0
quart-v0.18.4: blinker<1.6
quart-v0.18.4: jinja2<3.1.0
quart-v0.18.4: Werkzeug<2.3.0
quart-v0.18.4: hypercorn<0.15.0
{py3.8}-quart: taskgroup==0.0.0a4

starlite-v1.48.1: starlite==1.48.1
starlite-v1.49.0: starlite==1.49.0
starlite-v1.50.2: starlite==1.50.2
Expand Down