-
Notifications
You must be signed in to change notification settings - Fork 556
tests: Update tox.ini #4777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
tests: Update tox.ini #4777
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The GQL integration will crash with
gql>=4.2.0b0
becauseclient.execute
now passes aGraphQLRequest
object, but the integration expects aDocumentNode
.Description: The update to
gql>=4.2.0b0
introduces a breaking change whereclient.execute
receives aGraphQLRequest
object instead of aDocumentNode
. The Sentry integration's patchedexecute
method passes this object to_data_from_document
, which expects aDocumentNode
. This will cause a runtime crash when helper functions likeget_operation_ast(document)
are called with the wrong object type. This will affect all users of the GQL integration who upgrade to the new version and make any GraphQL request.Suggested fix: In the patched
execute
method, check if thedocument
argument is an instance ofGraphQLRequest
. If so, extract theDocumentNode
from its.document
attribute before passing it to the_data_from_document
function. This will restore compatibility with the newgql
version's API.severity: 0.85, confidence: 0.98
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a real concern, though it's already in 4.0.0. I'll make a separate PR for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4779