-
Notifications
You must be signed in to change notification settings - Fork 554
Global scope setters #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
untitaker
merged 14 commits into
getsentry:master
from
a-d-collins:global-scope-setters
Oct 23, 2019
Merged
Global scope setters #540
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fbb40b0
master: (sentry_sdk/utils.py) add push_scope_decorator
a-d-collins 3592c0f
master: (sentry_sdk/utils.py) fix iteritems incompatibility
a-d-collins 3406239
master: (sentry_sdk/utils.py) reformat push_scope_decorator() to fit …
a-d-collins 4b6d510
push-scope-decorator: (utils.py) remove push_scope_decorator, (hub.py…
a-d-collins aaa1c0b
push-scope-decorator: (sentry_sdk/hub.py) have _PushScopeContextDecor…
a-d-collins 9e0d94b
push-scope-decorator: (sentry_sdk/hub.py) combine _PushScopeContextDe…
a-d-collins 27c82c8
push-scope-decorator: (hub.py) fix push_scope() typing
a-d-collins 31d8dfb
master: (sentry_sdk/_compat.py, sentry_sdk/hub.py) resolve py2 Contex…
a-d-collins 1e52628
master: (sentry_sdk/scope.py) remove improper uses of @_attr_setter, …
a-d-collins 74dedb0
master: (tests/test_basics.py) add test for push_scope as decorator, …
a-d-collins d290b33
global-scope-setters: keep global scope setters and remove push_scope…
a-d-collins 7275b16
global-scope-setters: (api.py) change 'current_scope' property to 'sc…
a-d-collins bacd5f7
global-scope-setters: (hub.py) add new lines in docstring to match st…
a-d-collins a997206
global-scope-setters: (api.py) add global for set_context
a-d-collins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine btw. We never documented this method