Skip to content

fix build multi variant releases #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 7, 2024
Merged

fix build multi variant releases #4125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84402a6
fix: use local variables in currentVariants.each loop in sentry.gradle
omidshafaei Sep 28, 2024
a2f5ac7
Update CHANGELOG.md
omidshafaei Oct 6, 2024
ce534fe
Merge branch 'main' into fix/build-for-multi-variant-releases
lucas-zimerman Oct 7, 2024
64a16bd
Merge branch 'main' into fix/build-for-multi-variant-releases
lucas-zimerman Oct 7, 2024
6f4a0be
Merge branch 'main' into fix/build-for-multi-variant-releases
krystofwoldrich Oct 7, 2024
c94adae
Update CHANGELOG.md
krystofwoldrich Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Upload source maps for all release variants on Android (not only the last found) ([#4125](https://github.com/getsentry/sentry-react-native/pull/4125))

## 5.33.2

### Fixes
Expand Down
9 changes: 3 additions & 6 deletions sentry.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,16 @@ gradle.projectsEvaluated {
def currentVariants = extractCurrentVariants(bundleTask, releases)
if (currentVariants == null) return

def variant = null
def releaseName = null
def versionCode = null
def previousCliTask = null
def applicationVariant = null

def nameCleanup = "${bundleTask.name}_SentryUploadCleanUp"
def nameModulesCleanup = "${bundleTask.name}_SentryCollectModulesCleanUp"
// Upload the source map several times if necessary: once for each release and versionCode.
currentVariants.each { key, currentVariant ->
variant = currentVariant[0]
releaseName = currentVariant[1]
versionCode = currentVariant[2]
def variant = currentVariant[0]
def releaseName = currentVariant[1]
def versionCode = currentVariant[2]
applicationVariant = currentVariant[3]

try {
Expand Down
Loading