fix(core/plugin): Ensure android plugin type safety #5098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justnero
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
| const cfg = withAppBuildGradle(config, config => { | ||
| if (config.modResults.language === 'groovy') { | ||
| config.modResults.contents = modifyAppBuildGradle(config.modResults.contents); | ||
| const cfg = withAppBuildGradle(config, appBuildGradle => { |
|
Overall looks good! I will do final checks tomorrow and if all good, I will approve it, |
antonis
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Thank your contribution @justnero 🙇
The changes LGTM!
Leaving the final approval/merge to @lucas-zimerman in case he has more feedback 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
packages/core/plugin/src/withSentryAndroidGradlePlugin.ts💡 Motivation and Context
Fixes #5097
💚 How did you test it?
And a manual change test on my project to verify it's actually the only reason.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
This probably misses the same
expect.toEqualassertions for other branches, but overall is guaranteed by the type safety itself.