Skip to content

Conversation

ste93cry
Copy link
Contributor

@ste93cry ste93cry commented Dec 2, 2021

As per title, I've updated PHPStan and PHP-CS-Fixer to their latest version. A good bunch of errors that are currently ignored in the PHPStan baseline can be removed once the new version with the support for the key-of type gets released.

@ste93cry ste93cry added this to the 4.2 milestone Dec 2, 2021
@ste93cry ste93cry requested a review from Jean85 December 2, 2021 19:00
@ste93cry ste93cry force-pushed the update-phpstan-and-phpcs branch from 89c8f0d to c53be72 Compare December 2, 2021 19:12
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ste93cry ste93cry force-pushed the update-phpstan-and-phpcs branch from c53be72 to 30d5e73 Compare December 13, 2021 19:11
@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@Jean85 Jean85 force-pushed the update-phpstan-and-phpcs branch from 30d5e73 to 2d780b9 Compare January 12, 2022 22:50
@github-actions github-actions bot closed this Jan 20, 2022
@ste93cry ste93cry reopened this Jan 20, 2022
@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@ste93cry ste93cry force-pushed the update-phpstan-and-phpcs branch from 64f4e89 to 44481af Compare February 10, 2022 18:32
@ste93cry ste93cry requested a review from Jean85 February 10, 2022 19:01
@Jean85 Jean85 merged commit 0c0b33c into master Feb 14, 2022
@Jean85 Jean85 deleted the update-phpstan-and-phpcs branch February 14, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants