Skip to content

Cleanup Init #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bitsandfoxes opened this issue Dec 5, 2022 · 0 comments · Fixed by #1103
Closed

Cleanup Init #1102

bitsandfoxes opened this issue Dec 5, 2022 · 0 comments · Fixed by #1103
Labels
Repository Maintenance

Comments

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Dec 5, 2022 •
edited by vaind
Loading

From @vaind suggestion here:

We could clean SentryUnity class a bit by extracting a non-static class with all the current code and have a single variable private static SentryUnitySdk? Instance that we set in init() and remove in close() (+ call its close() of course).
SentryUnitySdk could have non-static and non-nullable Options, SentrySdk and FileStream lockfile.
@bitsandfoxes bitsandfoxes mentioned this issue Dec 5, 2022
Merged
@bitsandfoxes bitsandfoxes changed the title Have Init return an IDisposable Cleanup Init Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Repository Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: Init getsentry/sentry-unity
2 participants
@vaind @bitsandfoxes