-
-
Notifications
You must be signed in to change notification settings - Fork 55
fix: Native layer not closing #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK, though maybe we could clean SentryUnity
class a bit by extracting a non-static class with all the current code and have a single variable private static SentryUnitySdk? Instance
that we set in init() and remove in close() (+ call its close() of course).
SentryUnitySdk
could have non-static and non-nullable Options, SentrySdk and FileStream lockfile`
WDYT?
Excellent point. |
On mobile, the native layer is getting set up during buildtime and is self-initializing.
If the SDK gets disabled during runtime (i.e. in the
Configure
callback, then the native layer needs to be closed down too.Additionally, there was no way to close the SDK and have the native layer close with it.