Skip to content

Configurable Unity Log level to Event and Breadcrumb #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
bruno-garcia opened this issue Mar 1, 2021 · 6 comments
Closed
1 of 2 tasks

Configurable Unity Log level to Event and Breadcrumb #60

bruno-garcia opened this issue Mar 1, 2021 · 6 comments
Labels
Feature New feature or request

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Mar 1, 2021

This issue describes this todo:

// TODO: MinBreadcrumbLevel
// options.MinBreadcrumbLevel

We should have a configurable minimum level for what becomes a breadcrumb and what becomes an event.
Similar to what other logging integrations do.

Example:
https://github.com/getsentry/sentry-dotnet/blob/357a0eb751414ca5cd7a8a1a476fdf5fa309bcb9/src/Sentry.Extensions.Logging/SentryLogger.cs#L119
and
https://github.com/getsentry/sentry-dotnet/blob/357a0eb751414ca5cd7a8a1a476fdf5fa309bcb9/src/Sentry.Extensions.Logging/SentryLogger.cs#L138

@bruno-garcia bruno-garcia changed the title Unity Log level Configurable Unity Log level to Event and Breadcrumb Mar 1, 2021
@bruno-garcia bruno-garcia added the Feature New feature or request label Mar 1, 2021
@bruno-garcia
Copy link
Member Author

With such a feature, we could configure the SDK to send an invite for what the warning seeing here as a crumb:

image

@oddgames-david
Copy link

+1 would like to limit reporting only to exceptions, errors still to be in breadcrumbs though.

@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Oct 20, 2022

This should mirror the behavior we have with MinimumBreadcrumbLevel and MinimumEventLevel in Sentry.Extensions.Logging. See https://docs.sentry.io/platforms/dotnet/guides/extensions-logging/#options

@oddgames-david
Copy link

oddgames-david commented Jul 3, 2023

Still want to see this. Unity developers rely on many 3rd party sdk's and generally error log is used as a "serious" log when something has gone wrong but hasn't actually broken the app and sometimes we cant change the code (or at least shouldn't have to since we'll need to update it later and make those changes again).

All you need to do is push Exception's over to Fatal and keep Errors as Errors and we can filter out on before send

@bitsandfoxes
Copy link
Contributor

You basically just want to be able to automatically separate exceptions from logged errors. I think everything should be in place within the UnityLogHandlerIntegration to make that work. The SDK won't be able to distinguish between LogException and an actual exception tho.

@bitsandfoxes
Copy link
Contributor

The "loglevel to breadcrumb" is now individually selectable even through the config window.
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
Status: Done
Archived in project
Development

No branches or pull requests

5 participants