fix: Logging integration captures tags and messages #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1135
Debug.unityLogger.LogError("HUE", "Something exploded!");would only captureHUE, but now it looks like this:Previously: We put
Sentry:as prefix to all logs coming from within the SDK. And then we checked all logs coming in through the LoggingIntegration for starting with that prefix.The
Formatchanges from{0}to{0}: {1}if there is a tag present. Which means if the SDK makes use of the tag instead of adding a prefix we save on checking every message.And if we make use of the
unityLoggerin our logger we save on having to route everything through an interceptor for our tests.win-win!