feat: Added ANR options #1181

bitsandfoxes · 2023-02-14T13:26:21Z

The ANR feature was missing an opt-out on the editor window. While at it I surfaced the timeout.

bitsandfoxes · 2023-02-14T13:26:56Z

src/Sentry.Unity.Editor/ConfigurationWindow/AdvancedTab.cs

+            {
+                options.Debug = EditorGUILayout.BeginToggleGroup(
+                    new GUIContent("Enable Debug Output", "Whether the Sentry SDK should print its " +
+                                                          "diagnostic logs to the console."),
+                    options.Debug);
+
+                options.DebugOnlyInEditor = EditorGUILayout.Toggle(
+                    new GUIContent("Only In Editor", "Only print logs when in the editor. Development " +
+                                                     "builds of the player will not include Sentry's SDK diagnostics."),
+                    options.DebugOnlyInEditor);
+
+                options.DiagnosticLevel = (SentryLevel)EditorGUILayout.EnumPopup(
+                    new GUIContent("Verbosity Level", "The minimum level allowed to be printed to the console. " +
+                                                      "Log messages with a level below this level are dropped."),
+                    options.DiagnosticLevel);
+
+                EditorGUILayout.EndToggleGroup();
+            }

-            options.DiagnosticLevel = (SentryLevel)EditorGUILayout.EnumPopup(
-                new GUIContent("Verbosity Level", "The minimum level allowed to be printed to the console. " +
-                                                  "Log messages with a level below this level are dropped."),
-                options.DiagnosticLevel);
+            EditorGUILayout.Space();
+            EditorGUI.DrawRect(EditorGUILayout.GetControlRect(false, 1), Color.gray);
+            EditorGUILayout.Space();

-            EditorGUILayout.EndToggleGroup();
+            {
+                options.AutoSessionTracking = EditorGUILayout.BeginToggleGroup(
+                    new GUIContent("Auto Session Tracking", "Whether the SDK should start and end sessions " +
+                                                            "automatically. If the timeout is reached the old session will" +
+                                                            "be ended and a new one started."),
+                    options.AutoSessionTracking);
+
+                options.AutoSessionTrackingInterval = EditorGUILayout.IntField(
+                    new GUIContent("Session Timeout [ms]", "The duration of time a session can stay paused " +
+                                                           "(i.e. the application has been put in the background) before " +
+                                                           "it is considered ended."),
+                    options.AutoSessionTrackingInterval);
+                options.AutoSessionTrackingInterval = Mathf.Max(0, options.AutoSessionTrackingInterval);
+                EditorGUILayout.EndToggleGroup();
+            }


Please disregard. This is just an added indentation to help navigate this file.

github-actions · 2023-02-14T13:27:21Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 630e667

bitsandfoxes · 2023-02-14T13:27:26Z

src/Sentry.Unity.Editor/ConfigurationWindow/AdvancedTab.cs

+            {
+                options.IosNativeSupportEnabled = EditorGUILayout.Toggle(
+                    new GUIContent("iOS Native Support", "Whether to enable Native iOS support to capture" +
+                                                         "errors written in languages such as Objective-C, Swift, C and C++."),
+                    options.IosNativeSupportEnabled);
+
+                options.AndroidNativeSupportEnabled = EditorGUILayout.Toggle(
+                    new GUIContent("Android Native Support", "Whether to enable Native Android support to " +
+                                                             "capture errors written in languages such as Java, Kotlin, C and C++."),
+                    options.AndroidNativeSupportEnabled);
+
+                options.WindowsNativeSupportEnabled = EditorGUILayout.Toggle(
+                    new GUIContent("Windows Native Support", "Whether to enable native crashes support on Windows."),
+                    options.WindowsNativeSupportEnabled);
+
+                options.MacosNativeSupportEnabled = EditorGUILayout.Toggle(
+                    new GUIContent("macOS Native Support", "Whether to enable native crashes support on macOS."),
+                    options.MacosNativeSupportEnabled);
+
+                options.LinuxNativeSupportEnabled = EditorGUILayout.Toggle(
+                    new GUIContent("Linux Native Support", "Whether to enable native crashes support on Linux."),
+                    options.LinuxNativeSupportEnabled);
+            }


Please disregard. This is just an added indentation to help navigate this file.

bitsandfoxes · 2023-02-14T13:27:33Z

src/Sentry.Unity.Editor/ConfigurationWindow/AdvancedTab.cs

+                options.Il2CppLineNumberSupportEnabled = EditorGUILayout.Toggle(
+                    new GUIContent("IL2CPP line numbers", "Whether the SDK should try to to provide line " +
+                                                          "numbers for exceptions in IL2CPP builds."),
+                    options.Il2CppLineNumberSupportEnabled);
+
+                if (options.Il2CppLineNumberSupportEnabled)
                {
-                    EditorGUILayout.HelpBox("The IL2CPP line number support relies on the Debug Symbol Upload to be properly set up.", MessageType.Error);
+                    if (!SentryUnityVersion.IsNewerOrEqualThan("2020.3"))
+                    {
+                        EditorGUILayout.HelpBox("The IL2CPP line number feature is supported from Unity version 2020.3 or newer and 2021.3  or newer onwards", MessageType.Warning);
+                    }
+                    else if (cliOptions is not null && !cliOptions.IsValid(null, EditorUserBuildSettings.development))
+                    {
+                        EditorGUILayout.HelpBox("The IL2CPP line number support relies on the Debug Symbol Upload to be properly set up.", MessageType.Error);
+                    }


Please disregard. This is just an added indentation to help navigate this file.

…y-unity into feat/anr-options

added options for ANR

6ce50f0

bitsandfoxes requested a review from vaind February 14, 2023 13:26

bitsandfoxes commented Feb 14, 2023

View reviewed changes

getsentry-bot and others added 6 commits February 14, 2023 13:28

Format code

7935763

Updated CHANGELOG.md

5969f61

Merge branch 'feat/anr-options' of https://github.com/getsentry/sentr…

d6f0e27

…y-unity into feat/anr-options

fixed timespan multiplication

acea888

timespan ticks

e44a11b

one more multiply

b84265d

vaind approved these changes Feb 21, 2023

View reviewed changes

Merge branch 'main' into feat/anr-options

630e667

bitsandfoxes merged commit da4fd61 into main Feb 22, 2023

bitsandfoxes deleted the feat/anr-options branch February 22, 2023 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added ANR options #1181

feat: Added ANR options #1181

bitsandfoxes commented Feb 14, 2023

bitsandfoxes Feb 14, 2023

github-actions bot commented Feb 14, 2023 •

edited

Loading

bitsandfoxes Feb 14, 2023

bitsandfoxes Feb 14, 2023

feat: Added ANR options #1181

feat: Added ANR options #1181

Conversation

bitsandfoxes commented Feb 14, 2023

bitsandfoxes Feb 14, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2023 • edited Loading

bitsandfoxes Feb 14, 2023

Choose a reason for hiding this comment

bitsandfoxes Feb 14, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2023 •

edited

Loading