Skip to content

fix: Add missing WER handler on Windows #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 31, 2024
Merged

fix: Add missing WER handler on Windows #1873

merged 10 commits into from
Oct 31, 2024

Conversation

bitsandfoxes
Copy link
Contributor

Fixes #1866

We're currently very explicit with what we copy over from the sentry-native build

<Exec WorkingDirectory="$(SentryNativeRoot)" Command="cmake -B build -D SENTRY_BACKEND=crashpad -D SENTRY_SDK_NAME=sentry.native.unity -S ."></Exec>
<Exec WorkingDirectory="$(SentryNativeRoot)" Command="cmake --build build --target sentry --config RelWithDebInfo --parallel"></Exec>
<Exec WorkingDirectory="$(SentryNativeRoot)" Command="cmake --build build --target crashpad_handler --config Release --parallel"></Exec>
<ItemGroup>
<NativeSdkArtifacts Include="$(SentryNativeRoot)build/crashpad_build/handler/Release/crashpad_handler.exe" />
<NativeSdkArtifacts Include="$(SentryNativeRoot)build/RelWithDebInfo/sentry.dll" />
<NativeSdkArtifacts Include="$(SentryNativeRoot)build/RelWithDebInfo/sentry.pdb" />
</ItemGroup>

We need to include the wer handler as well.

@bitsandfoxes bitsandfoxes marked this pull request as ready for review October 31, 2024 12:08
@bitsandfoxes bitsandfoxes requested a review from vaind October 31, 2024 12:10
@bitsandfoxes bitsandfoxes merged commit ead6b6d into main Oct 31, 2024
89 of 90 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/windows-wer branch October 31, 2024 14:43
@bruno-garcia
Copy link
Member

Do we have anything on the docs about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing crashpad_wer.dll in windows platform
3 participants