fix: Logging during option creation, Configure and Init
#1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Jan 10, 2025
bitsandfoxes
commented
Jan 13, 2025
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Logging during `option creation`, `Configure` and `Init` ([#1959](https://github.com/getsentry/sentry-unity/pull/1959))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we've setup logging before calling the user's
Configurecallback. But by doing so, we're ignoring changes to the options until the SDK itself initializes. That way, if theScriptableUnityOptionswould not havedebugenabled, we'd miss out on all debug logs between option creation and initialization - That's native configuration in this case.