fix: iOS native bridge creation with parameters #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/io.sentry.unity/SentryNativeBridge.m:37:9: error: performSelector names a selector which retains the object
ysle0
changed the title
|
Thanks for contributing! ❤️ |
bitsandfoxes
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in #1951 (comment)
The original code that starts the iOS native bridge caused
compile error by XCode due to the retaining excessive ownership which can lead to a memory leak.
error name during the compilation:
"PerformSelector names a selector which retains the object".
this fix with PR was already been created by @bitsandfoxes
but thanks to him I could create my own PR for the first time.
I really appreciate the community.