Force 'Auto' from sentry window #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated |
There was a problem hiding this comment.
We can merge this but I used the programatic approach and turns out it doesn't default to Auto there so it ends up breaking IL2CPP.
So basically what we need is to always set base.CompressionLevel = NoCompression through the SetDefaults method so that's done regardless of how SentryUnityOptions is created
|
Changed to |
bitsandfoxes
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217
I decided to force
Autoif you configure from sentry window. We can differentiate between scripting backends with the following codebut it's available only in
Unity.Editor.dll. We could do that logic not on options level, but on window level itself.Which path should we take?
PS. Please notice, I didn't include tests as I'm trying to understand which approach we take.